Revize e5272be8

Repair anti-pattern too long sprint

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/DatabaseConnection.java

@@ -94 +94 @@
         return allResults;
     }
 
-    public List<Map<String,Object>> resultSetToArrayList(ResultSet rs) throws SQLException {
+    private List<Map<String,Object>> resultSetToArrayList(ResultSet rs) throws SQLException {
         ResultSetMetaData md = rs.getMetaData();
         int columns = md.getColumnCount();
         List<Map<String, Object>> list = new ArrayList<>();

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/TooLongSprintDetectorImpl.java

@@ -12 +12 @@
 import java.sql.SQLException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Map;
 
 public class TooLongSprintDetectorImpl implements AntiPatternDetector {
 
@@ -34 +35 @@
      * SETTINGS
      */
     private static final int MAX_NUMBER_OF_TOO_LONG_ITERATIONS = 1;
+    private static final int MAX_ITERATION_LENGTH = 21;
 
 
     @Override
@@ -69 +71 @@
         int numberOfLongIterations = 0;
         int totalCountOfIteration = 0;
 
-        // get results from sql queries
-        try {
-            ResultSet rs = databaseConnection.executeQueries(project, this.sqlQueries);
-            if (rs != null) {
-                while (rs.next()) {
-                    totalCountOfIteration++;
-                    boolean isTooLongSprint = rs.getBoolean("isTooLongSprint");
-                    if (isTooLongSprint) {
-                        numberOfLongIterations++;
-                    }
-                }
-            }
+        List<List<Map<String, Object>>> resultSets = databaseConnection.executeQueriesWithMultipleResults(project, this.sqlQueries);
+        List<Map<String, Object>> rs = resultSets.get(0);
 
-        } catch (SQLException e) {
-            LOGGER.error("Cannot read results from db");
-            List<ResultDetail> resultDetails = new ArrayList<>();
-            resultDetails.add(new ResultDetail("Problem in reading database", e.toString()));
-            return new QueryResultItem(this.antiPattern, true, resultDetails);
+        for (Map<String, Object> iterationLengths : rs) {
+            totalCountOfIteration++;
+            if (!iterationLengths.containsKey("iterationLength") || iterationLengths.get("iterationLength") == null)
+                continue;
+            int iterationLength = (int) iterationLengths.get("iterationLength");
+            if (iterationLength > MAX_ITERATION_LENGTH) {
+                numberOfLongIterations++;
+            }
         }
-
         List<ResultDetail> resultDetails = new ArrayList<>();
-        resultDetails.add(new ResultDetail("Count of iterations", String.valueOf(totalCountOfIteration)));
+        resultDetails.add(new ResultDetail("Count of iterations without first and last", String.valueOf(totalCountOfIteration)));
         resultDetails.add(new ResultDetail("Number of too long iterations", String.valueOf(numberOfLongIterations)));
         if (numberOfLongIterations >= MAX_NUMBER_OF_TOO_LONG_ITERATIONS) {
             resultDetails.add(new ResultDetail("Conclusion", "One or more iteration is too long"));

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/VaryingSprintLengthDetectorImpl.java

@@ -73 +73 @@
 
         // init values
         List<ResultDetail> resultDetails = new ArrayList<>();
-        int counter = 0;
+        int iterationLengthChanged = 0;
         int numberOfIterations = 0;
 
         try {
@@ -92 +92 @@
                     }
 
                     if (Math.abs(firstIterationLength - secondIterationLength) >= MAXIMUM_DAYS_DIFFERENCE) {
-                        counter = counter + 1;
+                        iterationLengthChanged = iterationLengthChanged + 1;
                     }
                     firstIterationLength = secondIterationLength;
                 }
@@ -106 +106 @@
 
         resultDetails.add(new ResultDetail("Maximum iteration length change", String.valueOf(MAXIMUM_ITERATION_CHANGE)));
         resultDetails.add(new ResultDetail("Count of iterations", String.valueOf(numberOfIterations)));
-        resultDetails.add(new ResultDetail("Iteration length changed", String.valueOf(counter)));
+        resultDetails.add(new ResultDetail("Iteration length changed", String.valueOf(iterationLengthChanged)));
 
 
-        if (counter >= MAXIMUM_ITERATION_CHANGE) {
+        if (iterationLengthChanged >= MAXIMUM_ITERATION_CHANGE) {
             resultDetails.add(new ResultDetail("Conclusion", "Iteration length changed significantly too often"));
         } else {
             resultDetails.add(new ResultDetail("Conclusion", "Varying iteration length is all right"));
@@ -118 +118 @@
         LOGGER.info(this.antiPattern.getPrintName());
         LOGGER.info(resultDetails.toString());
 
-        return new QueryResultItem(this.antiPattern, (counter >= MAXIMUM_ITERATION_CHANGE), resultDetails);
+        return new QueryResultItem(this.antiPattern, (iterationLengthChanged >= MAXIMUM_ITERATION_CHANGE), resultDetails);
     }
 }

src/main/webapp/queries/too_long_sprint.sql

@@ -14 +14 @@
 
 /* Init project id */
 set @projectId = ?;
-/* Maximum iteration length in days */
-set @maxSprintLength = 21;
 /* Exclude first and last iteration? */
-set @excludeFirstAndLastIteration = false;
+set @excludeFirstAndLastIteration = true;
 /* Id of first iteration */
 set @idOfFirstIteration = (select id from iteration where iteration.superProjectId = @projectId order by name limit 1);
 /* Id of last iteration */
 set @idOfLastIteration = (select id from iteration where iteration.superProjectId = @projectId order by name desc limit 1);
-/* Select all too long iterations */
-select datediff(iteration.endDate, iteration.startDate) as `iterationLength`, if(datediff(iteration.endDate, iteration.startDate) > @maxSprintLength, true, false) as `isTooLongSprint`, iteration.startDate as `iterationStartDate` from iteration where iteration.superProjectId = @projectId and iteration.id != if(@excludeFirstAndLastIteration = true, @idOfFirstIteration, -1) and iteration.id != if(@excludeFirstAndLastIteration = true, @idOfLastIteration, -1) order by iteration.name;
+/* Select all iterations with their length */
+select datediff(endDate, startDate) as `iterationLength` from iteration where iteration.superProjectId = @projectId and iteration.id != if(@excludeFirstAndLastIteration = true, @idOfFirstIteration, -1) and iteration.id != if(@excludeFirstAndLastIteration = true, @idOfLastIteration, -1) order by iteration.name;