Revize dbc30010

Configuration - Business As Usual

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BusinessAsUsualDetectorImpl.java

@@ -1 +1 @@
 package cz.zcu.fav.kiv.antipatterndetectionapp.detecting.detectors;
 
 import cz.zcu.fav.kiv.antipatterndetectionapp.detecting.DatabaseConnection;
-import cz.zcu.fav.kiv.antipatterndetectionapp.model.AntiPattern;
-import cz.zcu.fav.kiv.antipatterndetectionapp.model.Project;
-import cz.zcu.fav.kiv.antipatterndetectionapp.model.QueryResultItem;
-import cz.zcu.fav.kiv.antipatterndetectionapp.model.ResultDetail;
+import cz.zcu.fav.kiv.antipatterndetectionapp.model.*;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -21 +18 @@
             "Business As Usual",
             "BusinessAsUsual",
             "Absence of a retrospective after individual " +
-                    "iterations or after the completion project.");
+                    "iterations or after the completion project.",
+            new HashMap<>() {{
+                put("divisionOfIterationsWithRetrospective", new Configuration<Float>("divisionOfIterationsWithRetrospective",
+                        "Division of iterations with retrospective",
+                        "Minimum percentage of the total number of iterations with a retrospective (0,1)", 0.66666f));
+            }});
 
     private final String sqlFileName = "business_as_usual.sql";
 
     // sql queries loaded from sql file
     private List<String> sqlQueries;
-
-    /**
-     * SETTINGS
-     */
-    private final float DIVISION_BUSINESS_AS_USUAL_ITERATIONS = (float) 1/3;
+    
+    private float getDivisionOfIterationsWithRetrospective() {
+        return (float) antiPattern.getConfigurations().get("divisionOfIterationsWithRetrospective").getValue();
+    }
 
     @Override
     public AntiPattern getAntiPatternModel() {
@@ -99 +100 @@
 
         }
 
-        int minRetrospectiveLimit =  totalNumberIterations.intValue() - Math.round(totalNumberIterations * DIVISION_BUSINESS_AS_USUAL_ITERATIONS);
+        int minRetrospectiveLimit =  Math.round(totalNumberIterations * getDivisionOfIterationsWithRetrospective());
 
         resultDetails.add(new ResultDetail("Min retrospective limit", String.valueOf(minRetrospectiveLimit)));
         resultDetails.add(new ResultDetail("Found retrospectives", String.valueOf(iterationsResults.size())));

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/service/AntiPatternServiceImpl.java

@@ -70 +70 @@
                             return false;
                         }
 
+                    } else if (antiPatternDetector.getAntiPatternModel().getConfigurations().get(configNames[i]).getValue().getClass() == Float.class) {
+                        try {
+                            antiPatternDetector.getAntiPatternModel().getConfigurations().get(configNames[i]).setValue((Float.parseFloat(configValues[i])));
+                        } catch (NumberFormatException e) {
+                            return false;
+                        }
                     }
-
-
                 }
             }
         }

src/main/webapp/WEB-INF/templates/configuration.html

@@ -34 +34 @@
                     <label th:text="${config.value.printName}" th:for="${config.value.name}"
                            class="col-sm-5 col-form-label"></label>
                     <div class="col-sm-5">
-                        <input th:value="${config.value.value}" type="number" class="form-control" th:id="${config.value.name}"
+                        <input th:value="${config.value.value}" class="form-control" th:id="${config.value.name}"
                                name="configValues">
                         <input th:value="${config.value.name}" style="display: none" class="form-control"
                                name="configNames">