Revize 8a1fe4e5

Extract all settings as constants

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BusinessAsUsualDetectorImpl.java

@@ -29 +29 @@
     private List<String> sqlQueries;
 
     /**
-     * Settings
+     * SETTINGS
      */
     private final float DIVISION_BUSINESS_AS_USUAL_ITERATIONS = (float) 1/3;
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/LongOrNonExistentFeedbackLoopsDetectorImpl.java

@@ -33 +33 @@
     private List<String> sqlQueries;
 
     /**
-     * Settings
+     * SETTINGS
      */
-    private final float DIVISION_LONG_OR_NON_FEEDBACK_ITERATIONS = (float) 1 / 3;
-
-    /* Settings */
-    private final int MINIMUM_NUMBER_OF_WIKI_PAGES = 1;
-    private final int MINIMUM_NUMBER_OF_ACTIVITIES = 1;
 
     @Override
     public AntiPattern getAntiPatternModel() {

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/NinetyNinetyRuleDetectorImpl.java

@@ -24 +24 @@
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
+    /**
+     * SETTINGS
+     */
+
     @Override
     public AntiPattern getAntiPatternModel() {
         return this.antiPattern;

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/RoadToNowhereDetectorImpl.java

@@ -28 +28 @@
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
-    /* Settings */
+    /**
+     * SETTINGS
+     */
     private final int MINIMUM_NUMBER_OF_WIKI_PAGES = 1;
     private final int MINIMUM_NUMBER_OF_ACTIVITIES = 1;
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/SpecifyNothingDetectorImpl.java

@@ -27 +27 @@
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
-    /* Settings */
+    /**
+     * SETTINGS
+     */
     private final int MINIMUM_NUMBER_OF_WIKI_PAGES = 1;
     private final int MINIMUM_NUMBER_OF_ACTIVITIES = 1;
     private final double MINIMUM_AVERAGE_LENGTH_OF_ACTIVITY_DESCRIPTION = 150;

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/TooLongSprintDetectorImpl.java

@@ -30 +30 @@
     // sql queries loaded from sql file
     private List<String> sqlQueries;
 
-    // TODO vytáhnout konstanty ZDE
+    /**
+     * SETTINGS
+     */
+    private static final int MAX_NUMBER_OF_TOO_LONG_ITERATIONS = 1;
 
 
     @Override
@@ -89 +92 @@
         List<ResultDetail> resultDetails = new ArrayList<>();
         resultDetails.add(new ResultDetail("Count of iterations", String.valueOf(totalCountOfIteration)));
         resultDetails.add(new ResultDetail("Number of too long iterations", String.valueOf(numberOfLongIterations)));
-        if (numberOfLongIterations >= 1) {
+        if (numberOfLongIterations >= MAX_NUMBER_OF_TOO_LONG_ITERATIONS) {
             resultDetails.add(new ResultDetail("Conclusion", "One or more iteration is too long"));
         } else {
             resultDetails.add(new ResultDetail("Conclusion", "All iterations in limit"));