Revize 6767b4e4

Minor changes

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BystanderApathyDetectorImpl.java

@@ -65 +65 @@
     }
 
     /**
+     * Detection procedure:
+     * 1) find all work units in the project
+     * 2) find number of contributors to each project
+     * 3) if there is only one contributor (author) in the work unit, the work unit is without cooperation
+     * 4) if there is certain percentage of work units without cooperation in all work unit number, the anti-pattern is detected
      *
+     * @param project model class for analyzed project
+     * @param databaseConnection database connection
+     * @param thresholds current thresholds
+     * @return detection result
      */
     @Override
     public QueryResultItem analyze(Project project, DatabaseConnection databaseConnection, Map<String, String> thresholds) {
@@ -81 +90 @@
 
             List<String> parameters = new ArrayList<>();
             parameters.add(result.get("id").toString());
-            parameters.add(result.get("authorId").toString());
+            //parameters.add(result.get("authorId").toString());
 
             List<String> substringsInvalidContributors = getSearchSubstringsInvalidContributors(thresholds);
             for(String substring : substringsInvalidContributors)
@@ -94 +103 @@
         }
 
         List<ResultDetail> resultDetails = new ArrayList<>();
+        resultDetails.add(new ResultDetail("Tasks total number", String.valueOf(workUnitsTotalCount)));
         resultDetails.add(new ResultDetail("Bystander tasks number", String.valueOf(bystanderAP)));
 
         float totalRatioOfBystanderTasks = (float) bystanderAP / workUnitsTotalCount;

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/LongOrNonExistentFeedbackLoopsDetectorImpl.java

@@ -28 +28 @@
             "select_average_iterations_length.sql",
             "select_number_of_iterations_with_substrings_in_activity.sql",
             "select_all_activities_with_substrings_and_last_modified_date_as_end_date.sql",
-            "select_project_start_date.sql",
-            "select_project_end_date.sql",
+            "select_project_start_date_by_iteration.sql",
+            "select_project_end_date_by_iteration.sql",
             "select_all_iterations_that_contains_wikipages_with_substrings.sql");
 
     // sql queries loaded from sql file
@@ -112 +112 @@
             switch (i) {
                 case 0:
                     totalNumberIterations = (long) rs.get(0).get("numberOfIterations");
+                    if(totalNumberIterations == 0) {
+                        List<ResultDetail> resultDetails = Utils.createResultDetailsList(
+                                new ResultDetail("Number of iterations", Long.toString(totalNumberIterations)),
+                                new ResultDetail("Number of iterations with feedback loops", Integer.toString(numberOfIterationsWhichContainsAtLeastOneActivityForFeedback)),
+                                new ResultDetail("Conclusion", "No iterations in the project"));
+                        return new QueryResultItem(this.antiPattern, false, resultDetails);
+                    }
                     break;
                 case 1:
                     averageIterationLength = ((BigDecimal) rs.get(0).get("averageIterationLength")).intValue();

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/UnknownPosterDetectorImpl.java

@@ -61 +61 @@
     }
 
     /**
+     * Detection procedure:
+     * 1) find all persons involved in the project
+     * 2) check if persons have full name filled in
+     * 3) select identities for unidentified persons
+     * 4) check if every person has filled in at least one of the information in one of used identities
+     *    (email, full name in description, valid nickname)
+     * 5) if there is at least one unidentified person, the anti-pattern is detected
      *
+     * @param project model class for analyzed project
+     * @param databaseConnection database connection
+     * @param thresholds current thresholds
+     * @return detection result
      */
     @Override
     public QueryResultItem analyze(Project project, DatabaseConnection databaseConnection, Map<String, String> thresholds) {

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/YetAnotherProgrammerDetectorImpl.java

@@ -9 +9 @@
 import cz.zcu.fav.kiv.antipatterndetectionapp.utils.Utils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.thymeleaf.spring5.processor.SpringTextareaFieldTagProcessor;
 
 import java.time.LocalDate;
 import java.time.LocalDateTime;
@@ -67 +68 @@
     }
 
     /**
+     * Detection procedure:
+     * 1) select start and end date of the project
+     * 2) select all persons involved in the project
+     * 3) get first involvement date for each person in the project
+     * 4) divide project into months
+     * 5) for each month (except first X months) get number of persons with first involvement in this month
+     * 6) if number of new persons in any month is more than Y, the anti-pattern is detected
      *
+     * @param project model class for analyzed project
+     * @param databaseConnection database connection
+     * @param thresholds current thresholds
+     * @return detection result
      */
     @Override
     public QueryResultItem analyze(Project project, DatabaseConnection databaseConnection, Map<String, String> thresholds) {

src/main/resources/queries/select_project_end_date.sql

@@ -1 +1 @@
 /* Get project end date */
-select endDate as 'projectEndDate' from iteration where superProjectId = @projectId order by endDate desc limit 1;
+select ifnull(endDate, date_format(now(), "%Y-%m-%d")) as "endDate" FROM project  where id = @projectId;

src/main/resources/queries/select_project_end_date_by_iteration.sql

@@ +1 @@
+/* Get project end date */
+select endDate as 'projectEndDate' from iteration where superProjectId = @projectId order by endDate desc limit 1;

src/main/resources/queries/select_project_start_date.sql

@@ -1 +1 @@
 /* Get project start date */
-select startDate as 'projectStartDate' from iteration where superProjectId = @projectId order by startDate limit 1;
+select startDate FROM project where id = @projectId;

src/main/resources/queries/select_project_start_date_by_iteration.sql

@@ +1 @@
+/* Get project start date */
+select startDate as 'projectStartDate' from iteration where superProjectId = @projectId order by startDate limit 1;

src/main/resources/queries/select_work_units_from_project.sql

@@ -1 +1 @@
 /* Select ids of work units of a project */
-select wuv.id, wuv.authorId from workUnitView wuv where wuv.projectId = @projectId;
+select wuv.id from work_unit wuv where wuv.projectId = @projectId;

src/main/webapp/WEB-INF/templates/about.html

@@ -16 +16 @@
 <!-- ./Navigation bar imported -->
 <div class="container">
     <h1>About</h1>
+    <p>
+        <strong>App version:</strong> 1.1.0
+        <br>
+        <strong>Author:</strong> Petr Štěpánek
+        <br>
+        <strong>E-mail:</strong> <a href="mailto:[e-mail]">[e-mail]</a>
+    </p>
+    <p>
+        This application is used to detect presence of anti-patterns in project management tools data. Ten selected anti-patterns are implemented in this application.
+    </p>
+    <hr>
     <p>
         <strong>App version:</strong> 1.0.0
         <br>