Revize 455a4035

Added logging and package refactor

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/ApplicationProperties.java

@@ -1 @@
-package cz.zcu.fav.kiv.antipatterndetectionapp;
-
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.core.env.Environment;
-import org.springframework.stereotype.Component;
-
-@Component
-public class ApplicationProperties {
-
-    @Autowired
-    private Environment environment;
-
-    public String getDataSourceUrl () {
-        return environment.getProperty("spring.datasource.url");
-    }
-
-    public String getDataSourceUsername() {
-        return environment.getProperty("spring.datasource.username");
-    }
-
-    public String getDataSourcePassword() {
-        return environment.getProperty("spring.datasource.password");
-    }
-}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/ServletInitializer.java

@@ -1 @@
-package cz.zcu.fav.kiv.antipatterndetectionapp;
-
-import org.springframework.boot.builder.SpringApplicationBuilder;
-import org.springframework.boot.web.servlet.support.SpringBootServletInitializer;
-
-public class ServletInitializer extends SpringBootServletInitializer {
-
-	@Override
-	protected SpringApplicationBuilder configure(SpringApplicationBuilder application) {
-		return application.sources(AntiPatternDetectionAppApplication.class);
-	}
-
-}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/SpringApplicationContext.java

@@ -1 @@
-package cz.zcu.fav.kiv.antipatterndetectionapp;
-
-import org.springframework.beans.BeansException;
-import org.springframework.context.ApplicationContext;
-import org.springframework.context.ApplicationContextAware;
-import org.springframework.context.annotation.Configuration;
-
-@Configuration
-public class SpringApplicationContext implements ApplicationContextAware {
-
-    static ApplicationContext applicationContext = null;
-
-    public void setApplicationContext(ApplicationContext context)    throws BeansException {
-        applicationContext = context;
-    }
-
-    /**
-     * Note that this is a static method which expose ApplicationContext
-     **/
-    public static ApplicationContext getContext(){
-        return applicationContext;
-    }
-}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/Utils.java

@@ -1 @@
-package cz.zcu.fav.kiv.antipatterndetectionapp;
-
-import java.io.BufferedReader;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.sql.Date;
-import java.time.LocalDate;
-import java.time.temporal.ChronoUnit;
-import java.util.ArrayList;
-import java.util.List;
-
-public class Utils {
-
-    public static String bindValues(String query, List<String> parameters) {
-        for (String parameter : parameters) {
-            query = query.replace("?", parameter);
-        }
-        return query;
-    }
-
-    public static List<String> loadQueryFromFile(String fileName) {
-        List<String> queries = new ArrayList<>();
-        InputStream is = Utils.class.getClassLoader().getResourceAsStream(fileName);
-        BufferedReader reader = new BufferedReader(new InputStreamReader(is));
-        try {
-            while (reader.ready()) {
-
-                String line = reader.readLine();
-                if (line.startsWith("select") || line.startsWith("set")) {
-                    queries.add(line);
-                }
-
-            }
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
-        return queries;
-    }
-
-    public static long daysBetween(Date firstDate, Date secondDate) {
-        //24-May-2017, change this to your desired Start Date
-        LocalDate dateBefore = firstDate.toLocalDate();
-        //29-July-2017, change this to your desired End Date
-        LocalDate dateAfter = secondDate.toLocalDate();
-        return ChronoUnit.DAYS.between(dateBefore, dateAfter);
-    }
-}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/controller/AppController.java

@@ -6 +6 @@
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.Query;
 import cz.zcu.fav.kiv.antipatterndetectionapp.service.AntiPatternService;
 import cz.zcu.fav.kiv.antipatterndetectionapp.service.ProjectService;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Controller;
 import org.springframework.ui.Model;
@@ -16 +18 @@
 @Controller
 public class AppController {
 
+    private final Logger LOGGER = LoggerFactory.getLogger(AppController.class);
+
     @Autowired
     private ProjectService projectService;
 

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/AntiPatternsEnum.java

@@ -1 @@
-package cz.zcu.fav.kiv.antipatterndetectionapp.detecting;
-
-public enum AntiPatternsEnum {
-
-    TooLongSprint(1L,
-            "TooLongSprint",
-            "Too Long Sprint - DONE",
-            "Iterations too long. (ideal iteration length is about 1-2 weeks, " +
-                    "maximum 3 weeks). It could also be detected here if the length " +
-                    "of the iteration does not change often (It can change at the " +
-                    "beginning and at the end of the project, but it should not " +
-                    "change in the already started project)."),
-
-    VaryingSprintLength(2L,
-            "VaryingSprintLength",
-            "Varying Sprint Length - DONE",
-            "The length of the sprint changes very often. " +
-                    "It is clear that iterations will be different " +
-                    "lengths at the beginning and end of the project, " +
-                    "but the length of the sprint should not change " +
-                    "during the project."),
-
-    RoadToNowhere(3L,
-            "RoadToNowhere",
-            "Road To Nowhere - DONE",
-            "The project is not sufficiently planned and therefore " +
-                    "takes place on an ad hoc basis with an uncertain " +
-                    "outcome and deadline. There is no project plan in the project."),
-
-    SpecifyNothing(4L,
-            "SpecifyNothing",
-            "Specify Nothing - DONE",
-            "The specification is not done intentionally. Programmers are " +
-                    "expected to work better without written specifications."),
-
-    BusinessAsUsual(5L,
-            "BusinessAsUsual",
-            "Business As Usual - DONE",
-            "Absence of a retrospective after individual " +
-                    "iterations or after the completion project."),
-
-    IndifferentSpecialist(6L,
-            "IndifferentSpecialist",
-            "Indifferent specialist",
-            "A team member who is a specialist in just one thing and does not want to learn new things. " +
-                    "He refuses to learn new things outside of his specialization. It often disparages other " +
-                    "\"technologies\". They reduce the seriousness of things that do not specialize in his specialization."),
-
-    LongOrNonExistentFeedbackLoops(7L,
-            "LongOrNonExistentFeedbackLoops",
-            "Long Or Non-Existent Feedback Loops",
-            "Long spacings between customer feedback or no feedback. The customer " +
-                    "enters the project and sees the final result. In the end, the customer " +
-                    "may not get what he really wanted. With long intervals of feedback, " +
-                    "some misunderstood functionality can be created and we have to spend " +
-                    "a lot of effort and time to redo it. ");
-
-
-
-
-    public final Long id;
-    public final String name;
-    public final String printName;
-    public final String description;
-
-    AntiPatternsEnum(Long id, String name, String printName, String description) {
-        this.id = id;
-        this.name = name;
-        this.printName = printName;
-        this.description = description;
-    }
-}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/DatabaseConnection.java

@@ -1 +1 @@
 package cz.zcu.fav.kiv.antipatterndetectionapp.detecting;
 
-import cz.zcu.fav.kiv.antipatterndetectionapp.ApplicationProperties;
-import cz.zcu.fav.kiv.antipatterndetectionapp.SpringApplicationContext;
+import cz.zcu.fav.kiv.antipatterndetectionapp.spring.ApplicationProperties;
+import cz.zcu.fav.kiv.antipatterndetectionapp.spring.SpringApplicationContext;
 
 import java.sql.Connection;
 import java.sql.DriverManager;

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/BusinessAsUsualDetectorImpl.java

@@ -1 +1 @@
 package cz.zcu.fav.kiv.antipatterndetectionapp.detecting.detectors;
 
+import cz.zcu.fav.kiv.antipatterndetectionapp.controller.AppController;
 import cz.zcu.fav.kiv.antipatterndetectionapp.detecting.DatabaseConnection;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.AntiPattern;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.Project;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.QueryResultItem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class BusinessAsUsualDetectorImpl implements AntiPatternDetector {
 
+    private final Logger LOGGER = LoggerFactory.getLogger(BusinessAsUsualDetectorImpl.class);
+
     private final AntiPattern antiPattern = new AntiPattern(3L,
             "Business As Usual",
             "BusinessAsUsual",

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/TooLongSprintDetectorImpl.java

@@ -4 +4 @@
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.AntiPattern;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.Project;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.QueryResultItem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class TooLongSprintDetectorImpl implements AntiPatternDetector {
 
+    private final Logger LOGGER = LoggerFactory.getLogger(TooLongSprintDetectorImpl.class);
+
     private final AntiPattern antiPattern = new AntiPattern(1L,
             "Too Long Sprint",
             "TooLongSprint",

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/detecting/detectors/VaryingSprintLengthDetectorImpl.java

@@ -4 +4 @@
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.AntiPattern;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.Project;
 import cz.zcu.fav.kiv.antipatterndetectionapp.model.QueryResultItem;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class VaryingSprintLengthDetectorImpl implements AntiPatternDetector {
 
+    private final Logger LOGGER = LoggerFactory.getLogger(VaryingSprintLengthDetectorImpl.class);
+
     private final AntiPattern antiPattern = new AntiPattern(2L,
             "Varying Sprint Length",
             "VaryingSprintLength",

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/repository/AntiPatternRepository.java

@@ -2 +2 @@
 
 import cz.zcu.fav.kiv.antipatterndetectionapp.detecting.detectors.AntiPatternDetector;
 import org.reflections.Reflections;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.stereotype.Component;
 
 import java.lang.reflect.InvocationTargetException;
@@ -12 +14 @@
 @Component
 public class AntiPatternRepository {
 
+    private final Logger LOGGER = LoggerFactory.getLogger(AntiPatternRepository.class);
+
     private List<AntiPatternDetector> antiPatternDetectors = init();
 
     private List<AntiPatternDetector> init() {
@@ -24 +28 @@
             }
         } catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException | InstantiationException e) {
             e.printStackTrace();
-            // TODO LOG
+            LOGGER.error("Cannot get all detectors with reflection", e);
         }
         return antiPatterns;
     }
@@ -35 +39 @@
 
     public AntiPatternDetector getAntiPatternById(Long id) {
         for (AntiPatternDetector antiPatternDetector : antiPatternDetectors) {
-            if(antiPatternDetector.getAntiPatternId().equals(id)) {
+            if (antiPatternDetector.getAntiPatternId().equals(id)) {
                 return antiPatternDetector;
             }
             return antiPatternDetector;

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/spring/ApplicationProperties.java

@@ +1 @@
+package cz.zcu.fav.kiv.antipatterndetectionapp.spring;
+
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.core.env.Environment;
+import org.springframework.stereotype.Component;
+
+@Component
+public class ApplicationProperties {
+
+    @Autowired
+    private Environment environment;
+
+    public String getDataSourceUrl () {
+        return environment.getProperty("spring.datasource.url");
+    }
+
+    public String getDataSourceUsername() {
+        return environment.getProperty("spring.datasource.username");
+    }
+
+    public String getDataSourcePassword() {
+        return environment.getProperty("spring.datasource.password");
+    }
+}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/spring/ServletInitializer.java

@@ +1 @@
+package cz.zcu.fav.kiv.antipatterndetectionapp.spring;
+
+import cz.zcu.fav.kiv.antipatterndetectionapp.AntiPatternDetectionAppApplication;
+import org.springframework.boot.builder.SpringApplicationBuilder;
+import org.springframework.boot.web.servlet.support.SpringBootServletInitializer;
+
+public class ServletInitializer extends SpringBootServletInitializer {
+
+	@Override
+	protected SpringApplicationBuilder configure(SpringApplicationBuilder application) {
+		return application.sources(AntiPatternDetectionAppApplication.class);
+	}
+
+}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/spring/SpringApplicationContext.java

@@ +1 @@
+package cz.zcu.fav.kiv.antipatterndetectionapp.spring;
+
+import org.springframework.beans.BeansException;
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.ApplicationContextAware;
+import org.springframework.context.annotation.Configuration;
+
+@Configuration
+public class SpringApplicationContext implements ApplicationContextAware {
+
+    static ApplicationContext applicationContext = null;
+
+    public void setApplicationContext(ApplicationContext context)    throws BeansException {
+        applicationContext = context;
+    }
+
+    /**
+     * Note that this is a static method which expose ApplicationContext
+     **/
+    public static ApplicationContext getContext(){
+        return applicationContext;
+    }
+}

src/main/java/cz/zcu/fav/kiv/antipatterndetectionapp/utils/Utils.java

@@ +1 @@
+package cz.zcu.fav.kiv.antipatterndetectionapp.utils;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.sql.Date;
+import java.time.LocalDate;
+import java.time.temporal.ChronoUnit;
+import java.util.ArrayList;
+import java.util.List;
+
+public class Utils {
+
+    public static String bindValues(String query, List<String> parameters) {
+        for (String parameter : parameters) {
+            query = query.replace("?", parameter);
+        }
+        return query;
+    }
+
+    public static List<String> loadQueryFromFile(String fileName) {
+        List<String> queries = new ArrayList<>();
+        InputStream is = Utils.class.getClassLoader().getResourceAsStream(fileName);
+        BufferedReader reader = new BufferedReader(new InputStreamReader(is));
+        try {
+            while (reader.ready()) {
+
+                String line = reader.readLine();
+                if (line.startsWith("select") || line.startsWith("set")) {
+                    queries.add(line);
+                }
+
+            }
+        } catch (IOException e) {
+            e.printStackTrace();
+        }
+        return queries;
+    }
+
+    public static long daysBetween(Date firstDate, Date secondDate) {
+        //24-May-2017, change this to your desired Start Date
+        LocalDate dateBefore = firstDate.toLocalDate();
+        //29-July-2017, change this to your desired End Date
+        LocalDate dateAfter = secondDate.toLocalDate();
+        return ChronoUnit.DAYS.between(dateBefore, dateAfter);
+    }
+}