Revize 272e6b50

re #9419 Made sure that the error message gets printed out only one per device

client/usb_detector/usb_reader.py

@@ -4 +4 @@
 import usb.util
 
 
+_invalid_devices = []
+
+
 def read_connected_devices():
-    logging.debug(f'reading all currently connected devices')
+    logging.debug("reading all currently connected devices")
     detected_devices = []
 
     busses = usb.busses()
@@ -13 +16 @@
     for bus in busses:
         devices = bus.devices
         for dev in devices:
+            device = {
+                "vendor_id": dev.idVendor,
+                "product_id": dev.idProduct
+            }
             serial_number = None
             device_info = usb.core.find(idProduct=dev.idProduct)
             try:
                 serial_number = usb.util.get_string(device_info, device_info.iSerialNumber)
             except:
-                # Failed to retrieve information from device
-                logging.info(f"device idVendor:{dev.idVendor} idProduct:{dev.idProduct} has invalid format")
-                pass
+                if device not in _invalid_devices:
+                    logging.warning(f"Could not retrieve serial number from device {device}")
+                    _invalid_devices.append(device)
 
             if serial_number is not None:
-                detected_devices.append({
-                    "vendor_id": dev.idVendor,
-                    "product_id": dev.idProduct,
-                    "serial_number": serial_number
-                })
+                if device in _invalid_devices:
+                    _invalid_devices.remove(device)
+
+                device["serial_number"] = serial_number
+                detected_devices.append(device)
 
     return detected_devices