Revize fc874c36

Re #8572 - Added tests for certificate deletion.

tests/integration_tests/rest_api/certificates_test.py

@@ -311 +311 @@
 
 def test_sign_by_non_ca(server):
     ret = make_end_cert(server, 2, "Fake intermediate cert s.r.o.", usage={
-            "CA": False,
-            "SSL": True,
-            "authentication": True,
-            "digitalSignature": True
-        })
+        "CA": False,
+        "SSL": True,
+        "authentication": True,
+        "digitalSignature": True
+    })
 
     assert ret.status_code == 201
 
@@ -327 +327 @@
     assert d["success"]
 
     ret = make_end_cert(server, 8, "End certificate signed by end certificate s.r.o.", usage={
-            "CA": False,
-            "SSL": True,
-            "authentication": False,
-            "digitalSignature": False
-        })
+        "CA": False,
+        "SSL": True,
+        "authentication": False,
+        "digitalSignature": False
+    })
 
     # TODO discussion -> assert ret.status_code == 400
     assert ret.status_code == 201
@@ -592 +592 @@
         assert not ret.json["success"]
         assert "No such certificate found." == ret.json["data"]
 
+
 def test_set_certificate_status(server):
     # Create certificate to be revoked later
     certificate = {
@@ -624 +625 @@
 
     # revoke the certificate
     revocation_body = {
-        "status":  "revoked",
+        "status": "revoked",
         "reason": "keyCompromise"
     }
     revoke_ret = server.patch(f"/api/certificates/{cert_id}", content_type="application/json", json=revocation_body)
@@ -643 +644 @@
 
     # set to valid again
     valid_body = {
-        "status":  "valid"
+        "status": "valid"
     }
     valid_ret = server.patch(f"/api/certificates/{cert_id}", content_type="application/json", json=valid_body)
 
@@ -698 +699 @@
     assert "data" in revoke_ret.json
     assert "success" in revoke_ret.json
     assert not revoke_ret.json["success"]
+
+
+def test_certificate_deletion(server):
+
+    # custom tree for checking node bijection w/ the actual certificate tree
+    all_certs = {}
+    parent_of = {}
+
+    ret = make_root_ca(server)
+    assert ret.json["success"]
+    root_id = ret.json["data"]
+    all_certs[root_id] = []
+
+    def add(add_fn, parent):
+        """
+        Add a node to the global tree (represented by `all_certs` and `parent_of`).
+        :param add_fn: node type
+        :param parent: parent node id
+        :return: new node id
+        """
+        json = add_fn(server, parent).json
+        assert json["success"]
+        new_id = json["data"]
+        all_certs[parent].append(new_id)
+        all_certs[new_id] = []
+        parent_of[new_id] = parent
+        return new_id
+
+    def remove(id):
+        """
+        Remove a node from the global tree (represented by `all_certs` and `parent_of`).
+        :param id:
+        :return:
+        """
+        removed = []
+
+        def dfs(t):
+            removed.append(t)
+            for child in all_certs[t]:
+                dfs(child)
+            del all_certs[t]
+
+        dfs(id)
+        if id != root_id:
+            all_certs[parent_of[id]].remove(id)
+        return removed
+
+    # create a chain of certificates
+    for i in range(10):
+        add(make_inter_ca, root_id + i)
+
+    # create a branch from the middle
+    last = add(make_inter_ca, root_id + 5)
+
+    for i in range(5):
+        add(make_inter_ca, last + i)
+
+    # add end certificates for bonus spice
+    add(make_end_cert, root_id + 10)
+    add(make_end_cert, root_id + 9)
+    last_end_id = add(make_end_cert, root_id + 16)
+
+    # check that all certificates were created successfully
+    assert last_end_id == root_id + 19
+
+    # for four pseudorandom nodes in the created tree (descending order, a is not an ancestor of b if a > b)
+    for target in (root_id + 14, root_id + 10, root_id + 3, root_id):
+        # try delete
+        ret = server.delete(f"/api/certificates/{target}")
+        assert ret.status_code == 200
+        json = ret.json
+        assert "data" in json
+        assert "success" in json
+        assert json["success"]
+
+        # for everything that should be removed
+        currently_removed = remove(target)
+        for cert_id in currently_removed:
+            # check if it actually is
+            ret = server.delete(f"/api/certificates/{cert_id}")
+            assert ret.status_code == 404
+            json = ret.json
+            assert "data" in json
+            assert "success" in json
+            assert not json["success"]
+
+            # twice, just in case
+            ret = server.get(f"/api/certificates/{cert_id}")
+            assert ret.status_code == 205   # TODO change to 404 after someone gets the issue assigned and resolves it
+            json = ret.json
+            assert "data" in json
+            assert "success" in json
+            assert not json["success"]
+
+        # for everything that should not be removed
+        for cert_id in all_certs:
+            # check that it exists
+            ret = server.get(f"/api/certificates/{cert_id}")
+            assert ret.status_code == 200
+            json = ret.json
+            assert "data" in json
+            assert "success" in json
+            assert json["success"]
+
+
+def test_certificate_deletion_invalid_params_1(server):
+    ret = server.delete("/api/certificates/120938")
+    assert ret.status_code == 404
+    assert not ret.json["success"]
+
+
+def test_certificate_deletion_invalid_params_2(server):
+    ret = server.delete("/api/certificates/a_big_number")
+    assert ret.status_code == 400
+    assert not ret.json["success"]