Revize d65b022d

Re #8578 - Cover private_key_repository tests
- created tests for functions create, read, read_all, update, delete
- (+) edited certificate_repository to the same stylistics

src/dao/certificate_repository.py

@@ -1 +1 @@
 from typing import Dict, List
 from sqlite3 import Connection, Cursor, Error
 
+from src.exceptions.database_exception import DatabaseException
 from src.model.certificate import Certificate
 from src.constants import *
 
@@ -70 +71 @@
                         self.cursor.execute(sql, values)
                         self.connection.commit()
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
         return last_id
 
@@ -114 +115 @@
                                                    certificate_row[5],
                                                    certificate_row[6])
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        if len(certificate_row) > 0:
-            return certificate
-        else:
-            return None
+        return certificate
 
     def read_all(self, filter_type: int = None):
         """
@@ -166 +164 @@
                                                 certificate_row[5],
                                                 certificate_row[6]))
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        if len(certificates) > 0:
-            return certificates
-        else:
-            return None
+        return certificates
 
     def update(self, certificate_id: int, certificate: Certificate):
         """
@@ -228 +223 @@
                     self.cursor.execute(sql, values)
                     self.connection.commit()
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        if self.cursor.rowcount > 0:
-            return True
-
-        return False
+        return self.cursor.rowcount > 0
 
     def delete(self, certificate_id: int):
         """
@@ -251 +243 @@
             self.cursor.execute(sql, values)
             self.connection.commit()
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
         return self.cursor.rowcount > 0
 
@@ -285 +277 @@
             self.cursor.execute(sql, values)
             self.connection.commit()
         except Error as e:
-            return e
-
-        if self.cursor.rowcount > 0:
-            return True
+            raise DatabaseException(e)
 
-        return False
+        return self.cursor.rowcount > 0
 
     def clear_certificate_revocation(self, certificate_id: int):
         """
@@ -312 +301 @@
             self.cursor.execute(sql, values)
             self.connection.commit()
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        return True
+        return self.cursor.rowcount > 0
 
     def get_all_revoked_by(self, certificate_id: int):
         """
@@ -359 +348 @@
                                                 certificate_row[5],
                                                 certificate_row[6]))
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        if len(certificates) > 0:
-            return certificates
-        else:
-            return None
+        return certificates
 
     def get_all_issued_by(self, certificate_id: int):
         """
@@ -409 +395 @@
                                                 certificate_row[5],
                                                 certificate_row[6]))
         except Error as e:
-            return e
+            raise DatabaseException(e)
 
-        if len(certificates) > 0:
-            return certificates
-        else:
-            return None
+        return certificates