Revize be2df9b7

Re #8575 - Added unit tests verifying that serial number is set when creating a self signed certificate

src/services/cryptography.py

@@ -106 +106 @@
             return self.__run_for_output(
                 ["genrsa", PRIVATE_KEY_ENCRYPTION_METHOD, "-passout", f"pass:{passphrase}", "2048"]).decode()
 
-    def create_sscrt(self, subject, key, config="", extensions="", key_pass=None, days=30, sn: int =None):
+    def create_sscrt(self, subject, key, config="", extensions="", key_pass=None, days=30, sn: int = None):
         """
         Creates a root CA
 
@@ -155 +155 @@
             # waiting for the passphrase to be typed in
             args.extend(["-passin", f"pass:{key_pass}"])
 
+            print(args)
+
             return self.__run_for_output(args, proc_input=bytes(key, encoding="utf-8")).decode()
 
     def __create_csr(self, subject, key, key_pass=""):

tests/unit_tests/services/cryptography/self_signed_cert_test.py

@@ -176 +176 @@
     assert cert_printed != cert_printed_2
     assert cert_printed_2 != cert_printed_3
     assert cert_printed != cert_printed_3
+
+
+def test_create_sscrt_with_serial_number(service):
+    # create a self signed certificate with a PK that is protected by a passphrase
+    private_key = service.create_private_key()
+
+    serial_number = 1024
+    serial_number_hex = hex(serial_number).replace("x", "")
+
+    # specify a serial number
+    cert = service.create_sscrt(Subject(common_name="Topnax", country="CZ"), private_key, sn=serial_number)
+    out = subprocess.check_output(["openssl", "x509", "-noout", "-in", "-", "-serial"],
+                                  input=bytes(cert, encoding="utf-8"), stderr=subprocess.STDOUT).decode()
+
+    assert f"serial={serial_number_hex}" in out
+
+
+def test_create_sscrt_with_negative_serial_number(service):
+    # create a self signed certificate with a PK that is protected by a passphrase
+    private_key = service.create_private_key()
+
+    # check whether negative serial number does not raise an exception
+    serial_number = -1024
+    serial_number_hex = hex(serial_number).replace("x", "")
+
+    # specify a serial number
+    cert = service.create_sscrt(Subject(common_name="Topnax", country="CZ"), private_key, sn=serial_number)
+    out = subprocess.check_output(["openssl", "x509", "-noout", "-in", "-", "-serial"],
+                                  input=bytes(cert, encoding="utf-8"), stderr=subprocess.STDOUT).decode()
+
+    assert f"serial={serial_number_hex}" in out