Revize 9c704fb1

Re #8571 - RestAPI testing

src/services/certificate_service.py

@@ -279 +279 @@
         if reason not in CERTIFICATE_REVOCATION_REASONS:
             raise RevocationReasonInvalidException(reason)
 
+        updated = False
         if status == STATUS_VALID:
-            self.certificate_repository.clear_certificate_revocation(id)
+            updated = self.certificate_repository.clear_certificate_revocation(id)
         elif status == STATUS_REVOKED:
             revocation_timestamp = int(time.time())
-            self.certificate_repository.set_certificate_revoked(id, str(revocation_timestamp), reason)
+            updated = self.certificate_repository.set_certificate_revoked(id, str(revocation_timestamp), reason)
+
+        if not updated:
+            raise CertificateNotFoundException(id)
 
     def get_subject_from_certificate(self, certificate: Certificate) -> Subject:
         """
@@ -348 +352 @@
 
     def __str__(self):
         return f"Certificate status '{self.status}' is not valid."
+
+
+class CertificateNotFoundException(Exception):
+    """
+    Exception that denotes that the caller was trying to set
+    a certificate to an invalid state
+    """
+
+    def __init__(self, id):
+        self.id = id
+
+    def __str__(self):
+        return f"Certificate id '{self.id}' does not exist."