Revize 28dd4ff0

Improved check_subject_is_valid_test.py by using test parametrization.

tests/unit_tests/services/certificate/check_subject_is_valid_test.py

@@ -13 +13 @@
     certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo", country="CZ"))
 
 
-def test_check_subject_is_valid_country_one_letters(certificate_service):
+def test_check_subject_is_valid_without_country_code(certificate_service):
+    certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo"))
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(""),
+        pytest.param("C"),
+        pytest.param("CCZ"),
+    ],
+)
+def test_check_subject_is_valid_country_one_letters(certificate_service, cc):
     with pytest.raises(InvalidSubjectAttribute) as e:
-        certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo", country="C"))
-    assert_invalid_subject_attribute_error(e)
-
-
-def test_check_subject_is_valid_country_three_letters(certificate_service):
-    with pytest.raises(InvalidSubjectAttribute) as e:
-        certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo", country="CZA"))
-    assert_invalid_subject_attribute_error(e)
-
-
-def test_check_subject_is_valid_empty_country(certificate_service):
-    with pytest.raises(InvalidSubjectAttribute) as e:
-        certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo", country=""))
+        certificate_service._CertificateService__check_subject_is_valid(Subject(common_name="Foo", country=cc))
     assert_invalid_subject_attribute_error(e)