Revize ed55c677

Re #8475 - Fixed minor bug in GET /api/certificates endpoint with filtering

src/controllers/certificates_controller.py

@@ +1 @@
+import json
 from datetime import datetime
 from itertools import chain
 from flask import request
@@ -214 +215 @@
         CertController.setup()                                                      # TODO remove after issue fixed
 
         targets = {ROOT_CA_ID, INTERMEDIATE_CA_ID, CERTIFICATE_ID}                  # all targets
-        if request.is_json:                                                         # if the request carries JSON data
-            data = request.get_json()                                               # get it
+
+        # the filtering parameter can be read as URL argument or as a request body
+        if request.is_json or "filtering" in request.args.keys():                   # if the request carries JSON data
+            if request.is_json:
+                data = request.get_json()                                           # get it
+            else:
+                data = {"filtering": json.loads(request.args["filtering"])}
             if FILTERING in data:                                                   # if the 'filtering' field exists
                 if isinstance(data[FILTERING], dict):                               # and it is also a 'dict'
                     if CA in data[FILTERING]:                                       # containing 'CA'

tests/integration_tests/rest_api/certificates_test.py

@@ -345 +345 @@
 
 
 def test_filtering(server):
+    ret = server.get("/api/certificates?filtering=%7B%22CA%22:true%7D")
+
+    assert ret.status_code == 200
+
+    assert "data" in ret.json
+    assert "success" in ret.json
+    assert ret.json["success"]
+
+    d = ret.json["data"]
+
+    assert all(c["usage"]["CA"] for c in d)
+
     ret = server.get("/api/certificates", json={"filtering": {"CA": True}})
 
     assert ret.status_code == 200