Revize d55b3aff

Added a global error handler for generic exceptions.
Covered the added global exception error handler in a test.

app.py

@@ -1 +1 @@
 import os
 
 from flask import Flask, redirect, request
-from injector import Injector
 from flask_injector import FlaskInjector
+from injector import Injector
+from werkzeug.exceptions import HTTPException
 
 from src.config import configuration
 from src.config.configuration import Configuration
@@ -101 +102 @@
     return certificate_controller.handle_database_error(e)
 
 
[e-mail](Exception)
+def generic_exception(e, certificate_controller: CertController):
+    if isinstance(e, HTTPException):
+        Logger.warning(f""" HTTPException occurred: "{str(e)}" """)
+        return str(e), e.code
+    return certificate_controller.handle_generic_exception(e)
+
+
 def initialize_app(application) -> bool:
     """
     Initializes the application

src/controllers/certificates_controller.py

@@ -67 +67 @@
 
 E_UNHANDLED_CRYPTOGRAPHY_ERROR = {"success": False, "data": "An unknown error has happened in the cryptography library."}
 E_UNHANDLED_DATABASE_ERROR = {"success": False, "data": "An unknown database error has happened."}
+E_UNHANDLED_ERROR = {"success": False, "data": "An unknown error has happened."}
 
 
 class CertController:
@@ -781 +782 @@
     def handle_database_error(e):
         Logger.error(f"An unhandled DatabaseException has been raised: {str(e)}")
         return E_UNHANDLED_DATABASE_ERROR, C_INTERNAL_SERVER_ERROR
+
+    @staticmethod
+    def handle_generic_exception(e):
+        Logger.error(f"An unknown Exception ({type(e)}) has been raised: {str(e)}")
+        return E_UNHANDLED_ERROR, C_INTERNAL_SERVER_ERROR

tests/integration_tests/rest_api/certificates_test.py

@@ -3 +3 @@
 # 2->3->4->5->6->7
 # 2->8->9
 from src.controllers.certificates_controller import E_IDENTITY_NAME_NOT_SPECIFIED, E_IDENTITY_PASSWORD_NOT_SPECIFIED, \
-    E_NO_CERTIFICATES_FOUND, E_UNHANDLED_CRYPTOGRAPHY_ERROR, E_UNHANDLED_DATABASE_ERROR
+    E_NO_CERTIFICATES_FOUND, E_UNHANDLED_CRYPTOGRAPHY_ERROR, E_UNHANDLED_DATABASE_ERROR, E_UNHANDLED_ERROR
 from src.exceptions.database_exception import DatabaseException
 from src.model.certificate import Certificate
 from src.services.cryptography import CryptographyException
@@ -1328 +1328 @@
     ret = make_root_ca(server)
     assert ret.status_code == 500
     assert ret.json == E_UNHANDLED_DATABASE_ERROR
+
+
+def test_generic_exception_handler(server, mocker):
+    def mock_raises_zero_division_exception(self, certificate_id: int):
+        raise ZeroDivisionError("Failure is the only option")
+
+    mocker.patch(
+        # patch create method of the CertificateRepository in such way that a ZeroDivisionError is raised
+        'src.dao.certificate_repository.CertificateRepository.read_all',
+        mock_raises_zero_division_exception
+    )
+
+    ret = server.get("/api/certificates")
+
+    assert ret.status_code == 500
+    assert ret.json == E_UNHANDLED_ERROR