Revize d53c2fdc

Re #8476 - Implemented and tested `get_cert_root(id)`.

app.py

@@ -30 +30 @@
     return CertController.get_certificate_details_by_id(id)
 
 
[e-mail]('/api/certificates/<id>/root', methods=["GET"])
+def get_cert_root(id):
+    return CertController.get_certificate_root_by_id(id)
+
+
 if __name__ == '__main__':
     host = "0.0.0.0"
     port = 5000

src/controllers/certificates_controller.py

@@ -29 +29 @@
 ID = "id"
 E_NO_ISSUER_FOUND = {"success": False,
                            "data": "No certificate authority with such unique ID exists."}
-E_NO_CERTIFICATES_FOUND = {"success": False, "data": "No certificates found."}
+E_NO_CERTIFICATES_FOUND = {"success": False, "data": "No such certificate found."}
 E_NOT_JSON_FORMAT = {"success": False, "data": "The request must be JSON-formatted."}
 E_CORRUPTED_DATABASE = {"success": False, "data": "Internal server error (corrupted database)."}
 E_GENERAL_ERROR = {"success": False, "data": "Internal server error (unknown origin)."}
@@ -250 +250 @@
                 )
             return {"success": True, "data": ret}
 
-
     @staticmethod
     def get_certificate_root_by_id(id):  # noqa: E501
         """get certificate's root of trust chain by ID
@@ -264 +263 @@
         """
         CertController.setup()  # TODO remove after issue fixed
 
-        if connexion.request.is_json:
-            id = IdParameter.from_dict(connexion.request.get_json())  # noqa: E501
-        return 'do some magic!'
+        try:
+            v = int(id)
+        except ValueError:
+            return E_WRONG_PARAMETERS, 400
+
+        cert = CERTIFICATE_SERVICE.get_certificate(v)
+
+        if cert is None:
+            return E_NO_CERTIFICATES_FOUND, 205  # TODO related to 204 issue
+
+        while cert.parent_id != cert.certificate_id:
+            cert = CERTIFICATE_SERVICE.get_certificate(cert.parent_id)
+            if cert is None:
+                return E_CORRUPTED_DATABASE, 500
+
+        return {"success": True, "data": cert.pem_data}
 
     @staticmethod
     def get_certificate_trust_chain_by_id(id):  # noqa: E501

tests/unit_tests/rest_api/certificates.py

@@ -151 +151 @@
     assert not d["success"]
 
 
-def test_root_inter_ca(server):
+def test_create_chain(server):
     ret = server.post("/api/certificates", content_type="application/json", json={
         "subject": {
             "C": "CZ",
@@ -209 +209 @@
     assert "success" in d
     assert d["success"]
 
+    ret = server.post("/api/certificates", content_type="application/json", json={
+        "CA": 3,
+        "subject": {
+            "C": "CZ",
+            "CN": "Legit end certificate s.r.o.",
+            "L": "Pilsen",
+            "O": "I swear s.r.o.",
+            "OU": "IT department",
+            "ST": "Pilsen Region",
+            "emailAddress": "[e-mail]"
+        },
+        "usage": {
+            "CA": True,
+            "SSL": True,
+            "authentication": True,
+            "digitalSignature": True
+        },
+        "validityDays": 30
+    })
+
+    assert ret.status_code == 201
+
+    d = ret.json
+
+    assert "data" in d
+    assert d["data"] == 4
+    assert "success" in d
+    assert d["success"]
+
 
 def test_list_of_certificates(server):
     ret = server.get("/api/certificates")
@@ -270 +299 @@
     d = ret.json
 
     assert "data" in d
-    assert d["data"] == 4
+    assert d["data"] == 5
     assert "success" in d
     assert d["success"]
 
     ret = server.post("/api/certificates", content_type="application/json", json={
-        "CA": 2,
+        "CA": 5,
         "subject": {
             "C": "CZ",
             "CN": "End certificate signed by end certificate s.r.o.",
@@ -300 +329 @@
     d = ret.json
 
     assert "data" in d
-    assert d["data"] == 5
+    assert d["data"] == 6
     assert "success" in d
     assert d["success"]
 
@@ -370 +399 @@
     assert "data" in ret.json
     assert "success" in ret.json
     assert not ret.json["success"]
-    assert ret.json["data"] == "No certificates found."
+    assert ret.json["data"] == "No such certificate found."
 
 
 def test_get_detes(server):
@@ -403 +432 @@
 
     d = ret.json
 
-    assert d["data"] == 6
+    assert d["data"] == 7
 
     id = d["data"]
 
@@ -421 +450 @@
 
     assert original["CA"] == new["CA"]
     assert original["subject"] == new["subject"]
-    assert original["usage"] == new["usage"]
+    assert original["usage"] == new["usage"]
+
+
+def test_get_root(server):
+    ret = server.get("/api/certificates/2")
+
+    assert ret.status_code == 200
+
+    assert "data" in ret.json
+    assert "success" in ret.json
+    assert ret.json["success"]
+
+    original = ret.json["data"]
+
+    ret = server.get("/api/certificates/4/root")
+
+    assert ret.status_code == 200
+
+    assert "data" in ret.json
+    assert "success" in ret.json
+    assert ret.json["success"]
+
+    new = ret.json["data"]
+
+    assert original == new
+
+
+def test_get_root_invalid(server):
+    ret = server.get("/api/certificates/805/root")
+
+    assert ret.status_code == 205
+    assert "data" in ret.json
+    assert "success" in ret.json
+    assert not ret.json["success"]
+    assert ret.json["data"] == "No such certificate found."
+