Revize d1c800c1

Added REST API tests covering whether specifying an invalid country code when making new certificate requests results in a Bad request HTTP status code and a particular response

tests/integration_tests/rest_api/certificates_test.py

@@ -2 +2 @@
 # 1->10
 # 2->3->4->5->6->7
 # 2->8->9
+import pytest
+
 from src.controllers.certificates_controller import E_IDENTITY_NAME_NOT_SPECIFIED, E_IDENTITY_PASSWORD_NOT_SPECIFIED, \
     E_NO_CERTIFICATES_FOUND
 
 
-def make_root_ca(server, title="Root CA s.r.o."):
+def make_root_ca(server, title="Root CA s.r.o.", cc="CZ"):
     return server.post("/api/certificates", content_type="application/json", json={
         "subject": {
-            "C": "CZ",
+            "C": cc,
             "CN": title,
             "L": "Pilsen",
             "O": title,
@@ -22 +24 @@
     })
 
 
-def make_inter_ca(server, parent, title="Intermediate CA s.r.o."):
+def make_inter_ca(server, parent, title="Intermediate CA s.r.o.", cc="CZ"):
     return server.post("/api/certificates", content_type="application/json", json={
         "CA": parent,
         "subject": {
-            "C": "CZ",
+            "C": cc,
             "CN": title,
             "L": "Pilsen",
             "O": title,
@@ -39 +41 @@
     })
 
 
-def make_end_cert(server, parent, title="End certificate s.r.o.", usage=None):
+def make_end_cert(server, parent, title="End certificate s.r.o.", usage=None, cc="CZ"):
     if usage is None:
         usage = ["SSL", "authentication", "digitalSignature"]
 
     return server.post("/api/certificates", content_type="application/json", json={
         "CA": parent,
         "subject": {
-            "C": "CZ",
+            "C": cc,
             "CN": title,
             "L": "Pilsen",
             "O": title,
@@ -1295 +1297 @@
                                json={"password": "foopass", "name": "Foo"})
     assert identity_ret.status_code == 404
     assert identity_ret.json == E_NO_CERTIFICATES_FOUND
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(""),
+        pytest.param("C"),
+        pytest.param("CCZ"),
+    ],
+)
+def test_invalid_subject_country_code(server, cc):
+    ret = make_root_ca(server, "Foo", cc)
+
+    assert ret.status_code == 400
+
+    d = ret.json
+
+    assert "data" in d
+    assert d["data"] == """Subject attribute "Country code" is invalid (reason: Must consist of exactly 2 letters)."""
+    assert "success" in d
+    assert not d["success"]
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(""),
+        pytest.param("C"),
+        pytest.param("CCZ"),
+    ],
+)
+def test_invalid_subject_country_code(server, cc):
+    root_ret = make_root_ca(server)
+    ret = make_inter_ca(server, root_ret.json["data"], "Foo", cc)
+
+    assert ret.status_code == 400
+
+    d = ret.json
+
+    assert "data" in d
+    assert d["data"] == """Subject attribute "Country code" is invalid (reason: Must consist of exactly 2 letters)."""
+    assert "success" in d
+    assert not d["success"]