Revize b484b79b

Covered test cases where CertificateService should/shouldn't raise InvalidSubjectAttribute error

tests/integration_tests/services/certificate_service_test.py

@@ -6 +6 @@
 from src.constants import SSL_ID, CA_ID, AUTHENTICATION_ID, INTERMEDIATE_CA_ID, ROOT_CA_ID, CERTIFICATE_ID, SIGNATURE_ID
 from src.model.subject import Subject
 from src.services.certificate_service import RevocationReasonInvalidException, CertificateStatusInvalidException, \
-    CertificateNotFoundException, CertificateAlreadyRevokedException, CertificateCannotBeSetToValid
+    CertificateNotFoundException, CertificateAlreadyRevokedException, CertificateCannotBeSetToValid, \
+    InvalidSubjectAttribute
 
 
 def export_crt(crt):
@@ -510 +511 @@
     assert root_ca_cert.pem_data in pkcs_info
     assert len(re.findall("BEGIN CERTIFICATE", pkcs_info)) == 1
     assert len(re.findall("END CERTIFICATE", pkcs_info)) == 1
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(None),
+        pytest.param("CZ")
+    ],
+)
+def test_create_root_ca_valid_cc(certificate_service, sample_private_key, cc):
+    # test whether create_root_ca does not throw any exception when valid country code is passed
+    certificate_service.create_root_ca(sample_private_key, Subject(common_name="Foo", country=cc))
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(None),
+        pytest.param("CZ"),
+    ],
+)
[e-mail](
+    "func",
+    [
+        "create_ca",
+        "create_end_cert"
+    ],
+)
+def test_create_certificate_valid_cc(certificate_service, sample_certificate, sample_private_key, cc, func):
+    # test whether create_ca and create_end_cert do not throw any exception when valid country code is passed
+    getattr(certificate_service, func)(sample_private_key, Subject(common_name="Foo", country=cc), sample_certificate,
+                                       sample_private_key)
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(""),
+        pytest.param("C"),
+        pytest.param("CCZ"),
+    ],
+)
+def test_create_root_ca_invalid_cc_length(certificate_service, private_key_service, cc):
+    # assert that create_root_ca raises an exception when an invalid subject country code is passed
+    with pytest.raises(InvalidSubjectAttribute) as e:
+        certificate_service.create_root_ca(private_key_service.create_new_key(), Subject(common_name="Foo", country=cc))
+    assert e.value.attribute_name == "Country code"
+    assert e.value.reason == "Must consist of exactly 2 letters"
+
+
[e-mail](
+    "cc",
+    [
+        pytest.param(""),
+        pytest.param("C"),
+        pytest.param("CCZ"),
+    ],
+)
[e-mail](
+    "func",
+    [
+        "create_ca",
+        "create_end_cert"
+    ],
+)
+def test_create_certificate_invalid_cc_length(certificate_service, sample_certificate, sample_private_key, cc, func):
+    # assert that create_ca and create_end_cert raise an exception when an invalid subject country code is passed
+    with pytest.raises(InvalidSubjectAttribute) as e:
+        getattr(certificate_service, func)(sample_private_key, Subject(common_name="Foo", country=cc),
+                                           sample_certificate, sample_private_key)
+    assert e.value.attribute_name == "Country code"
+    assert e.value.reason == "Must consist of exactly 2 letters"

tests/integration_tests/services/conftest.py

@@ -9 +9 @@
 from src.dao.certificate_repository import CertificateRepository
 from src.dao.private_key_repository import PrivateKeyRepository
 from src.db.init_queries import SCHEMA_SQL, DEFAULT_VALUES_SQL
+from src.model.subject import Subject
 from src.services.certificate_service import CertificateService
 from src.services.crl_ocsp.crl_ocsp_service import CrlOcspService
 from src.services.cryptography import CryptographyService
@@ -57 +58 @@
     return ConnectionProvider().connect(test_configuration())
 
 
[e-mail]
+def sample_private_key(private_key_service):
+    return private_key_service.create_new_key()
+
+
[e-mail]
+def sample_certificate(certificate_service, sample_private_key):
+    return certificate_service.create_root_ca(sample_private_key, Subject("Foo"))
+
+
 # scope defaults to "function" which means that the fixture is run once per test (function)
 @pytest.fixture
 def certificate_repository_unique(connection_unique):