Revize 8a5e37dd

Re #8708 - Improved /api/certificate/{id}/identity test coverage by testing to send non well formed requests

tests/integration_tests/rest_api/certificates_test.py

@@ -2 +2 @@
 # 1->10
 # 2->3->4->5->6->7
 # 2->8->9
+from src.controllers.certificates_controller import E_IDENTITY_NAME_NOT_SPECIFIED, E_IDENTITY_PASSWORD_NOT_SPECIFIED, \
+    E_NO_CERTIFICATES_FOUND
 
 
 def make_root_ca(server, title="Root CA s.r.o."):
@@ -958 +960 @@
     assert identity_ret.status_code == 200
     assert identity_ret.content_type == "application/x-pkcs12"
 
+
+def test_generate_identity_non_well_formed(server):
+    # non integer ID
+    identity_ret = server.get(f"/api/certificates/foo/identity", content_type="application/json",
+                              json={})
+    assert identity_ret.status_code == 400
+
+    # required fields not passed
+    identity_ret = server.get(f"/api/certificates/0/identity", content_type="application/json",
+                              json={})
+    assert identity_ret.status_code == 400
+    assert identity_ret.json == E_IDENTITY_NAME_NOT_SPECIFIED
+
+    # passphrase not passed
+    identity_ret = server.get(f"/api/certificates/0/identity", content_type="application/json",
+                              json={"name": "Foo"})
+    assert identity_ret.status_code == 400
+    assert identity_ret.json == E_IDENTITY_PASSWORD_NOT_SPECIFIED
+
+    # name not passed
+    identity_ret = server.get(f"/api/certificates/0/identity", content_type="application/json",
+                              json={"password": "foopass"})
+    assert identity_ret.status_code == 400
+    assert identity_ret.json == E_IDENTITY_NAME_NOT_SPECIFIED
+
+    # certificate not existing
+    identity_ret = server.get(f"/api/certificates/0/identity", content_type="application/json",
+                              json={"password": "foopass", "name": "Foo"})
+    assert identity_ret.status_code == 404
+    assert identity_ret.json == E_NO_CERTIFICATES_FOUND