Revize 7a30da1b

Added a new exception that is thrown when a subject with an invalid attribute is passed while creating a new certificate via CertificateService.

src/services/certificate_service.py

@@ -49 +49 @@
         self.certificate_repository = certificate_repository
         self.configuration = configuration
 
+    @staticmethod
+    def __check_subject_is_valid(subject: Subject):
+        if subject.country is not None and len(subject.country) != 2:
+            raise InvalidSubjectAttribute("Country code", "Must consist of exactly 2 letters.")
+
     # TODO usages present in method parameters but not in class diagram
     def create_root_ca(self, key: PrivateKey, subject: Subject, extensions: str = "", config: str = "",
                        usages=None, days=30):
@@ -65 +70 @@
 
         Logger.debug("Function launched.")
 
+        # check whether the given subject is valid
+        self.__check_subject_is_valid(subject)
+
         if usages is None:
             usages = {}
 
@@ -137 +145 @@
 
         Logger.debug("Function launched.")
 
+        # check whether the given subject is valid
+        self.__check_subject_is_valid(subject)
+
         if usages is None:
             usages = {}
 
@@ -188 +199 @@
 
         Logger.debug("Function launched.")
 
+        # check whether the given subject is valid
+        self.__check_subject_is_valid(subject)
+
         if usages is None:
             usages = {}
 
@@ -601 +615 @@
         return "Cannot set revoked certificate back to valid when the certificate revocation reason is not " \
                "certificateHold. " \
                f"The revocation reason of the certificate is {self.old_state}"
+
+
+class InvalidSubjectAttribute(Exception):
+    """
+    Exception that denotes that the caller was trying to
+    create a certificate while passing a subject with an invalid
+    attribute.
+    """
+
+    def __init__(self, attribute_name, reason):
+        self.attribute_name = attribute_name
+        self.reason = reason
+
+    def __str__(self):
+        return f"""Subject attribute "{self.attribute_name} is invalid (reason: {self.reason})."""