Revize 5f8a2c07

Re #8572 - Extended the method in the CertificateService.

src/services/certificate_service.py

@@ -256 +256 @@
 
         return chain_of_trust
 
-    def delete_certificate(self, unique_id) -> bool:
+    def delete_certificate(self, unique_id):
         """
-        Deletes a certificate
+        Deletes a certificate. Raises an Exception should any unexpected behavior occur.
 
         :param unique_id: ID of specific certificate
-
-        :return: `True` when the deletion was successful. `False` in other case
         """
-        # TODO delete children?
-        return self.certificate_repository.delete(unique_id)
+
+        to_delete = self.certificate_repository.get_all_descendants_of(unique_id)
+        if to_delete is None:
+            raise CertificateNotFoundException(unique_id)
+
+        for cert in to_delete:
+            try:
+                self.set_certificate_revocation_status(cert.certificate_id, STATUS_REVOKED)
+            except CertificateAlreadyRevokedException:
+                # TODO log as an info/debug, not warning or above <-- perfectly legal
+                continue
+
+            self.certificate_repository.delete(cert.certificate_id)
+            # TODO log if not successfully deleted
 
     def set_certificate_revocation_status(self, id, status, reason="unspecified"):
         """