Revize 2166bb21

Added a global error handler for DatabaseException errors.
Covered the added global DatabaseException error handler in a test.

app.py

@@ -9 +9 @@
 from src.config.connection_provider import ConnectionProvider
 from src.controllers.certificates_controller import CertController
 from src.controllers.crl_ocsp_controller import CrlOcspController
+from src.exceptions.database_exception import DatabaseException
 from src.services.cryptography import CryptographyService, CryptographyException
 from src.utils.logger import Logger
 
@@ -95 +96 @@
     return certificate_controller.handle_cryptography_error(e)
 
 
[e-mail](DatabaseException)
+def database_error(e, certificate_controller: CertController):
+    return certificate_controller.handle_database_error(e)
+
+
 def initialize_app(application) -> bool:
     """
     Initializes the application

src/controllers/certificates_controller.py

@@ -66 +66 @@
                                                   "It may be caused by wrong format of extensions."}
 
 E_UNHANDLED_CRYPTOGRAPHY_ERROR = {"success": False, "data": "An unknown error has happened in the cryptography library."}
+E_UNHANDLED_DATABASE_ERROR = {"success": False, "data": "An unknown database error has happened."}
 
 
 class CertController:
@@ -775 +776 @@
     def handle_cryptography_error(e):
         Logger.error(f"An unhandled CryptographyException has been raised: {str(e)}")
         return E_UNHANDLED_CRYPTOGRAPHY_ERROR, C_INTERNAL_SERVER_ERROR
+
+    @staticmethod
+    def handle_database_error(e):
+        Logger.error(f"An unhandled DatabaseException has been raised: {str(e)}")
+        return E_UNHANDLED_DATABASE_ERROR, C_INTERNAL_SERVER_ERROR

tests/integration_tests/rest_api/certificates_test.py

@@ -3 +3 @@
 # 2->3->4->5->6->7
 # 2->8->9
 from src.controllers.certificates_controller import E_IDENTITY_NAME_NOT_SPECIFIED, E_IDENTITY_PASSWORD_NOT_SPECIFIED, \
-    E_NO_CERTIFICATES_FOUND, E_UNHANDLED_CRYPTOGRAPHY_ERROR
+    E_NO_CERTIFICATES_FOUND, E_UNHANDLED_CRYPTOGRAPHY_ERROR, E_UNHANDLED_DATABASE_ERROR
+from src.exceptions.database_exception import DatabaseException
+from src.model.certificate import Certificate
 from src.services.cryptography import CryptographyException
 
 
@@ -1311 +1313 @@
     ret = make_root_ca(server)
     assert ret.status_code == 500
     assert ret.json == E_UNHANDLED_CRYPTOGRAPHY_ERROR
+
+
+def test_database_error_handler(server, mocker):
+    def mock_raises_database_error(self, certificate: Certificate):
+        raise DatabaseException("Could not create a certificate.")
+
+    mocker.patch(
+        # patch create method of the CertificateRepository  in such way that a DatabaseException is raised
+        'src.dao.certificate_repository.CertificateRepository.create',
+        mock_raises_database_error
+    )
+
+    ret = make_root_ca(server)
+    assert ret.status_code == 500
+    assert ret.json == E_UNHANDLED_DATABASE_ERROR