Revize cbb91c90

Re #8915 - Zapracování požadavků ze schůzky

+ sensor edit under edit button in menu

• request for sensor data only for first time, then after button click
  + sensor group names
  + adding information to unit and sensor
  + commenting
  + code refactor

src/app/dashboard/components/dashboard.component.ts

@@ -1 @@
-import { Component, OnInit } from '@angular/core';
+import {Component, OnDestroy, OnInit} from '@angular/core';
 import {Group} from '../../shared/api/endpoints/models/group';
 import {Drivers} from '../../shared/api/endpoints/models/drivers';
 import {GeneralInfo} from '../../shared/api/endpoints/models/general-info';
@@ -16 +16 @@
 import {AuthService} from '../../auth/services/auth.service';
 import {User} from '../../auth/models/user';
 import {SensorType} from '../../shared/api/endpoints/models/sensor-type';
+import {Subscription} from 'rxjs';
 
 @Component({
   selector: 'app-dashboard',
   templateUrl: './dashboard.component.html',
   styleUrls: ['./dashboard.component.scss']
 })
-export class DashboardComponent implements OnInit {
+export class DashboardComponent implements OnInit, OnDestroy {
 
   loggedUser: User;
   items: MenuItem[] = [];
@@ -35 +36 @@
   showInsertPositionPopup = false;
   phenomenons: Phenomenon[];
   sensorTypes: SensorType[];
+  subscription: Subscription[] = [];
 
   constructor(
     private dataService: DataService,
@@ -45 +47 @@
     private toastService: ToastService,
     private authService: AuthService
   ) {
+    this.initData();
+  }
+
+  ngOnInit(): void {
+  }
+
+  /**
+   * Unsubscribe after leaving
+   */
+  ngOnDestroy(): void {
+    this.subscription.forEach(subs => subs.unsubscribe());
+  }
+
+  /**
+   * Get necessary data from backend
+   */
+  initData() {
     this.sensorService.getPhenomenons().subscribe(
       response => this.phenomenons = response
     );
     this.sensorService.getSensorTypes().subscribe(
       response => this.sensorTypes = response
     );
-  }
-
-  ngOnInit(): void {
     this.setUser();
     this.getUnits();
   }
 
+  /**
+   * Get user from user state
+   */
   setUser(){
     this.authService.getUserState().subscribe(res => {
       if(res){
@@ -66 +85 @@
     });
   }
 
+  /**
+   * Get all units and theirs sensors from backend
+   */
   getUnits() {
     this.dataService.getData().subscribe(data => {
       this.units = data;
@@ -73 +95 @@
     }, err => this.toastService.showError(err.error.message));
   }
 
+  /**
+   * Show edit unit
+   * @param $event click event
+   * @param unit edited unit
+   */
   editUnitPopup($event: MouseEvent, unit: Unit) {
     this.editedUnit = unit;
     this.showEditUnitPopup = true;
   }
 
+  /**
+   * Show insert unit
+   * @param $event click event
+   * @param unit unit for sensor insert
+   */
   insertSensorPopup($event: any, unit: Unit) {
     this.showInsertSensorPopup = true;
     this.editedUnit = unit;
   }
 
+  /**
+   * Detele unit confirmation
+   * @param $event click event
+   * @param unit unit to delete
+   */
   deleteUnit($event: any, unit: Unit) {
     this.confirmationService.confirm({
       message: 'Do you want to delete this unit?',
@@ -98 +135 @@
     });
   }
 
+  /**
+   * Send delete unit request to backend
+   * @param unit to delete
+   */
   processUnitDeletion(unit: Unit) {
     this.managementService.deleteUnit$Response({body: {
       unit: {
@@ -114 +155 @@
     ).toPromise().then().catch(err => this.toastService.showError(err.error.message));
   }
 
+  /**
+   * Show menu items to manipulate with unit
+   * @param $event click event
+   * @param unit unit we want edit
+   */
   showItems($event: any, unit: Unit) {
     $event.stopPropagation();
     this.items = [
@@ -132 +178 @@
     ]
   }
 
+  /**
+   * Add created unit to memory so we do not need call backend
+   * @param inserted unit
+   */
   addUnit(inserted: any) {
     const sensors: Sensor[] = [];
     inserted.sensors.forEach(sens => {
@@ -153 +203 @@
     })
   }
 
+  /**
+   * Add created sensors to unit in memory so we do not need call backend
+   * @param inserted sensors
+   */
   addSensors(inserted: any) {
     inserted.sensors.forEach(sens => {
       this.units.find(un => un.unit.unitId === inserted.unit.unit_id).sensors.push({
@@ -166 +220 @@
     });
   }
 
+  /**
+   * Delete sensor from memory
+   * @param unitId sensor unit
+   * @param sensor sensor to delete
+   */
   deleteSensor(unitId: number, sensor: Sensor) {
     this.units.find(unit => unit.unit.unitId === unitId).sensors =
       this.units.find(unit => unit.unit.unitId === unitId).sensors.filter(testedSensor => testedSensor.sensorId !== sensor.sensorId);
   }
 
-  private insertPosition($event: any, unit: Unit) {
+  /**
+   * Show insert position popup
+   * @param $event click event
+   * @param unit unit to insert position for
+   */
+  insertPosition($event: any, unit: Unit) {
     $event.stopPropagation();
     this.showInsertPositionPopup = true;
     this.editedUnit = unit;