Revize 90b699e9

re #41 fix some todos

server/src/main/java/org/danekja/ymanager/domain/GoogleUser.java

@@ -18 +18 @@
     private static final String HOSTED_DOMAIN = "hd";
 
     private final OidcIdToken idToken;
+    private final Collection<? extends GrantedAuthority> authorities;
 
     public GoogleUser(Long id, UserData userData, OidcIdToken idToken) {
         super(id, userData);
         this.idToken = idToken;
+        this.authorities = Collections.singleton(new SimpleGrantedAuthority(userData.getRole().name()));
     }
 
     public GoogleUser(OidcIdToken idToken) {
         this.idToken = idToken;
+        this.authorities = Collections.emptySet();
     }
 
     public String subjectId() {
@@ -73 +76 @@
 
     @Override
     public Collection<? extends GrantedAuthority> getAuthorities() {
-        //TODO do not create collection on each call
-        return Collections.singleton(new SimpleGrantedAuthority(userData.getRole().name()));
+        return authorities;
     }
 
     @Override

server/src/main/java/org/danekja/ymanager/domain/RegisteredUser.java

@@ -45 +45 @@
      */
     private LocalDateTime creationDate;
 
+    /**
+     * Granted authorities.
+     */
+    private final Collection<? extends GrantedAuthority> authorities;
+
     public RegisteredUser() {
+        this.authorities = Collections.emptySet();
     }
 
     public RegisteredUser(Long id, String firstName, String lastName, String email, String photo, LocalDateTime creationDate, UserData userData) {
@@ -56 +62 @@
         this.email = email;
         this.photo = photo;
         this.creationDate = creationDate;
+        this.authorities = Collections.singleton(new SimpleGrantedAuthority(userData.getRole().name()));
     }
 
     /*
@@ -63 +70 @@
  */
     @Override
     public Collection<? extends GrantedAuthority> getAuthorities() {
-        //TODO do not create collection on each call
-        return Collections.singleton(new SimpleGrantedAuthority(userData.getRole().name()));
+        return authorities;
     }
 
     @Override

server/src/main/java/org/danekja/ymanager/repository/jdbc/JdbcSettingsRepository.java

@@ -25 +25 @@
 
     @Override
     public DefaultSettings get() {
-        //TODO order by creation date
-        return this.jdbc.queryForObject("SELECT * FROM default_settings ORDER BY id DESC LIMIT 1", SETTINGS_ROW_MAPPER);
+        return this.jdbc.queryForObject("SELECT * FROM default_settings ORDER BY creation_date DESC, id DESC LIMIT 1", SETTINGS_ROW_MAPPER);
     }
 
 }